Skip to content
This repository has been archived by the owner on Dec 9, 2024. It is now read-only.

Move to Most Recent Alpaka Version + Newest Caching Allocator #314

Merged
merged 8 commits into from
Aug 29, 2023

Conversation

GNiendorf
Copy link
Member

@GNiendorf GNiendorf commented Jul 31, 2023

Moves to gcc11 and CMSSW_13_0_0_pre4 (same as current CMSSW integration) in order to upgrade to the most recent version of Alpaka used by CMSSW. Also gets rid of our temporary hyperbolic functions and replaces them with Alpaka's which were introduced into Alpaka recently.

@GNiendorf GNiendorf marked this pull request as ready for review July 31, 2023 16:53
@GNiendorf GNiendorf changed the title Move to Most Recent Alpaka Version Move to Most Recent Alpaka Version + Newest Caching Allocator Jul 31, 2023
@GNiendorf
Copy link
Member Author

GNiendorf commented Aug 6, 2023

Comparison plots: Here
This PR: Here
Current Master: Here

Given that Philip is probably busy, I'll leave it to them to open a PR later on if this configuration doesn't work on their machine. Example timing on the Cornell machine given below. @VourMa This PR should be good to merge in.

Screenshot 2023-08-06 at 3 03 18 PM

@GNiendorf GNiendorf requested a review from VourMa August 6, 2023 18:59
@GNiendorf
Copy link
Member Author

GNiendorf commented Aug 7, 2023

Just added Andrea's last commit which was pushed recently. We should be good to merge this in now.

@YonsiG
Copy link
Contributor

YonsiG commented Aug 28, 2023

Hi Gavin, sorry for the late review and thank you for the efforts! I checked the external LST package and it runs smoothly. However, I met an error when compiling the LST set up as CMSSW external.

When I did scram b -j 12, after the cms-checkdeps in README, it says:
/home/users/yagu/TrackLooper_Ntuple/test_PR314/workingFolder/CMSSW_13_0_0_pre4/src/RecoTracker/LST/plugins/alpaka/LSTProducer.cc:46:43: error: cannot bind non-const lvalue reference of type 'CUstream_st*&' to an rvalue of type 'CUstream_st*'
46 | lst_.run(ctx.queue().getNativeHandle(),

I'm not sure if the error comes with issues in this PR, but it would be nice if you have any ideas.

@GNiendorf
Copy link
Member Author

@YonsiG This is something not in the readme yet, but you need to remove the .getNativeHandle() from LSTProducer.cc

Or you can use the Alpaka integration branch where this is fixed

@YonsiG
Copy link
Contributor

YonsiG commented Aug 28, 2023

@YonsiG This is something not in the readme yet, but you need to remove the .getNativeHandle() from LSTProducer.cc

Or you can use the Alpaka integration branch where this is fixed

Thanks Gavin. Can you put this in the README also? Or what is the consequence of removing this line in the LSTProducer.cc directly if it causes issues not only in the Alpaka branch?

@GNiendorf
Copy link
Member Author

@YonsiG Just updated the README as you suggested. The CMSSW integration steps should work now.

@YonsiG
Copy link
Contributor

YonsiG commented Aug 29, 2023

Thanks Gavin, I tested the codes on external packages, and test the CMSSW integration with cmsRun. Everything works smoothly on my side. Thanks for contribution and PR merged!

@YonsiG YonsiG merged commit 8517040 into master Aug 29, 2023
@GNiendorf GNiendorf deleted the alpaka_upgrade branch March 26, 2024 14:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants